-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the infobar for WDP CTA instead of dialog #15822
Conversation
34ce2d8
to
1493918
Compare
We'll use infobar for WDP cta.
916bdad
to
31fd043
Compare
d977aa2
to
d5d8c77
Compare
d5d8c77
to
714b52b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
lgtm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Looks good @simonhong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks all for review :) |
@@ -10,6 +12,12 @@ source_set("brave_wayback_machine") { | |||
"brave_wayback_machine_infobar_throbber.h", | |||
"brave_wayback_machine_infobar_view.cc", | |||
"brave_wayback_machine_infobar_view.h", | |||
"custom_styled_label.cc", | |||
"custom_styled_label.h", | |||
"web_discovery_infobar_content_view.cc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this in brave_wayback_machine?
fix brave/brave-browser#26576
Deleted previous WDP dialog.
Use Infobar UI for WDP CTA instead of modal dialog.
And removed bottom shadow from infobar container.
Light mode
Dark mode
This custom infobar has below three state based on width.
Wide layout with wide horizontal padding
Wide layout with narrow horizontal padding
Narrow layout
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
npm run test brave_unit_tests -- --filter=WebDiscoveryCTATest*
npm run test brave_browser_tests -- --filter=WebDiscoveryTest*
last_displayed
time like deleting last digit to simulate time passed more than 1 day from user dir'sPreferences
file after shutdownNo thanks
and check infobar is not shown anymoreid
in above Preferences to any other string